fix(Entity): Do not add Array.prototype properties to store #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds like this is hard to reproduce. Any chance you can isolate it into a unit test that fails on current version but passes with this fix? |
|
I simply cannot reproduce it in the unit tests. But I think I have found the root cause. My project uses In general, iterating over an array with |
livthomas
force-pushed
the
entity-null
branch
from
f30509c
to
f311f39
Compare
livthomas
changed the title
|
@MikeRyanDev, I have added a reproducer here as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to fix issue #781 and verified the problem is really no longer there by building my application (where I can always reproduce the problem) with a version of
@ngrx/entitycontaining these changes.